Framework: Add missing JSX rules for eslint #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirbrillig
added
Framework
[Status] Needs Review
* react/jsx-uses-vars: Prevent variables used in JSX to be incorrectly marked as unused * react/jsx-no-undef: Disallow undeclared variables in JSX * react/react-in-jsx-scope: Prevent missing React when using JSX
sirbrillig
force-pushed
the
add/jsx-eslint-rules
branch
from
35e6fd5 to
cdc32d5
Compare
|
dare i check to see how much this added to the eslint report... :) |
|
looks like it didn't find anything new, we're still at 14,173 warnings. 🎉 |
|
ship it, looks good! |
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
😄 I'm glad to hear it, since anything this found would be a JS syntax error. Will merge tomorrow. |
blowery
added a commit
that referenced
this pull request
Dec 18, 2015
Framework: Add missing JSX rules for eslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Edit a JSX file that has no eslint errors and make some changes to see errors appear:
import(orrequire) line that imports a component.React.createClass, but does render JSX code, remove theimport(orrequire) line that importsReact.