Build: fix the node-version rule. #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow I broke this with the last commit on #1204 and didn't notice. This re-instates the call to `check-node-version` to inform folks on old nodes that they need to upgrade
blowery
added
[Status] Needs Review
|
|
sirbrillig
added
[Status] Ready to Merge
and removed
[Status] Needs Review
blowery
added a commit
that referenced
this pull request
Dec 18, 2015
Build: fix the node-version rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow I broke this with the last commit on #1204 and didn't notice.
This re-instates the call to
check-node-versionto inform folks on old nodes that they need to upgrade.To test, downgrade to node v12.x.x and try to run
make installormake lint.