Extensions: Zoninator - Implement the data layer for Zoninator's zone locks #21209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice9js
force-pushed
the
add/zoninator-locks-data-layer
branch
from
778e79b
to
cad0260
Compare
ice9js
force-pushed
the
add/zoninator-locks-data-layer
branch
from
cad0260
to
097f61a
Compare
ice9js
force-pushed
the
add/zoninator-locks-data-layer
branch
from
097f61a
to
57f241d
Compare
ice9js
added
[Status] Needs Review
dmsnell
approved these changes
Jan 14, 2018
ice9js
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the data-layer needed to request zone locks in the Zoninator extension.
It's fairly straight forward - requesting a lock and dispatching an
updateLockaction when successful andrequestLockErrorotherwise.No error notices are displayed on error. That'll be handled specifically in the Edit Zone UI as you won't be able to make any changes as long as the lock isn't successful.
The lock endpoint is implemented in Automattic/zoninator#64.
Testing
npm run test-client client/extensions/zoninator/state/data-layer/locks