Reader: reflect list title changes in sidebar #2153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors in sidebar list
…derListsSubscriptionsStore, so title changes are reflected in sidebar
bluefuton
added
[Status] Needs Review
|
cc @blowery |
|
nice, looks good! 🚢 not this PR, but I think it's about time we break the sidebar into separate components. y/n/m? |
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Big yes from me. I was thinking perhaps get #724 merged, then have a tidy-up PR. |
bluefuton
added a commit
that referenced
this pull request
Jan 12, 2016
…nges-in-sidebar Reader: reflect list title changes in sidebar
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a Reader list title, the title should be reflected in the sidebar list.
For example, in this screenshot, the first list in the sidebar should also be entitled 'ABC1234':
Fixes #2065.