Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Settings: remove feature flag for language selector #21771

Merged

Conversation

frontdevde
Copy link
Contributor

@frontdevde frontdevde commented Jan 23, 2018

This PR

We're a version check for the minimum version of Jetpack, which makes the feature flag obsolete.

How to test

Follow the instructions in #21482

@matticbot
Copy link
Contributor

@frontdevde frontdevde added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 23, 2018
@frontdevde frontdevde self-assigned this Jan 23, 2018
@frontdevde frontdevde requested a review from jblz January 23, 2018 22:34
Copy link
Member

@jblz jblz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@frontdevde frontdevde merged commit e66ba1a into master Jan 23, 2018
@frontdevde frontdevde deleted the update/site-settings/remove-language-selector-feature-flag branch January 23, 2018 23:08
@lancewillett
Copy link
Contributor

w00t! Great work @frontdevde and Team Samus/Delta.

@sirreal sirreal removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Settings: can't set locale options for Jetpack sites
5 participants