-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Onboarding: Add country field to business address step #22580
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked great! Leaving and observation but it's not exclusive to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
☝️ oops, apologies for accidental button click. |
@oskosk, red fields are an indication of a required input, which makes sense if no address has been provided. This should be filled-in and green when the step had been completed before. |
f9c6dc4
to
e57db06
Compare
@@ -55,6 +56,7 @@ class JetpackOnboardingBusinessAddressStep extends React.PureComponent { | |||
city: translate( 'City' ), | |||
state: translate( 'State / Region / Province' ), | |||
zip: translate( 'ZIP code' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I've found a possible matching string that has already been translated 34 times:
translate( 'Zip Code' )
ES Score: 15
See 2 additional suggestions in the PR translation status page
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
@AnnaMag it looked to me at first glance like if the field contents were not valid. There was a bug months ago when you reached the signup form and all of them where read and read that they were invalid (they had the clarification below the error though). I had the same feeling here, associating the red to something that I did wrong. |
This PR adds a country field to the business address step. It also updates the settings schema to respect that field. Suggested in p6TEKc-1Rd-p2 and #22530.
Fixes #22530.
Preview:
To test:
/wp-admin/admin.php?page=jetpack&action=onboard&calypso_env=development