Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Onboarding: Improve Business Address field labels #22581

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Feb 19, 2018

This PR updates the labels of the Business Address step as suggested in p6TEKc-1Rd-p2 and #22530. Changes are basically:

  • Business Name to Business name
  • Street Address to Street address
  • State to State / Region / Province
  • ZIP Code to ZIP code

Before:

After:

To test:

  • Checkout this branch
  • Checkout the Jetpack branch from REST API: Add Country field to Business Address onboarding step jetpack#8874 on your Jetpack site.
  • Start the onboarding flow for the Jetpack site by going to /wp-admin/admin.php?page=jetpack&action=onboard&calypso_env=development
  • On the site type step, choose Business
  • Skip to the Business Address step.
  • Verify the field labels appear as shown on the "After" screenshot.

@tyxla tyxla added [Type] Enhancement [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Jetpack Onboarding labels Feb 19, 2018
@matticbot
Copy link
Contributor

state: translate( 'State' ),
zip: translate( 'ZIP Code' ),
state: translate( 'State / Region / Province' ),
zip: translate( 'ZIP code' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I've found a possible matching string that has already been translated 34 times:
translate( 'Zip Code' ) ES Score: 15
See 2 additional suggestions in the PR translation status page

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

city: translate( 'City' ),
state: translate( 'State' ),
zip: translate( 'ZIP Code' ),
state: translate( 'State / Region / Province' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I've found a possible matching string that has already been translated 58 times:
translate( 'State/Province' ) ES Score: 7

Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).

@@ -50,11 +50,11 @@ class JetpackOnboardingBusinessAddressStep extends React.PureComponent {
const { translate } = this.props;

return {
name: translate( 'Business Name' ),
street: translate( 'Street Address' ),
name: translate( 'Business name' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 This change is safe, we'll keep the existing 24 translations.

Copy link
Contributor

@AnnaMag AnnaMag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tyxla
Copy link
Member Author

tyxla commented Feb 20, 2018

Will merge this as it's consistent with the latest mockups, @joanrho @rickybanister if you have any suggestions for improvement, we can iterate later.

@tyxla tyxla merged commit 98dbd35 into master Feb 20, 2018
@tyxla tyxla deleted the update/jpo-ba-improve-labels branch February 20, 2018 11:18
@tyxla tyxla removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants