-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Onboarding: Improve Business Address field labels #22581
Conversation
state: translate( 'State' ), | ||
zip: translate( 'ZIP Code' ), | ||
state: translate( 'State / Region / Province' ), | ||
zip: translate( 'ZIP code' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I've found a possible matching string that has already been translated 34 times:
translate( 'Zip Code' )
ES Score: 15
See 2 additional suggestions in the PR translation status page
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
city: translate( 'City' ), | ||
state: translate( 'State' ), | ||
zip: translate( 'ZIP Code' ), | ||
state: translate( 'State / Region / Province' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I've found a possible matching string that has already been translated 58 times:
translate( 'State/Province' )
ES Score: 7
Help me improve these suggestions: react with 👎 if the suggestion doesn't make any sense, or with 👍 if it's a particularly good one (even if not implemented).
@@ -50,11 +50,11 @@ class JetpackOnboardingBusinessAddressStep extends React.PureComponent { | |||
const { translate } = this.props; | |||
|
|||
return { | |||
name: translate( 'Business Name' ), | |||
street: translate( 'Street Address' ), | |||
name: translate( 'Business name' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗 This change is safe, we'll keep the existing 24 translations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Will merge this as it's consistent with the latest mockups, @joanrho @rickybanister if you have any suggestions for improvement, we can iterate later. |
This PR updates the labels of the Business Address step as suggested in p6TEKc-1Rd-p2 and #22530. Changes are basically:
Business Name
toBusiness name
Street Address
toStreet address
State
toState / Region / Province
ZIP Code
toZIP code
Before:
After:
To test:
/wp-admin/admin.php?page=jetpack&action=onboard&calypso_env=development