SSR: Mark masterbar and layout files as @ssr-ready
#2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehg
added
[Feature Group] Appearance & Themes
ehg
force-pushed
the
update/mark-masterbar-ssr-ready
branch
from
e47d61b to
e14d790
Compare
ehg
added
[Status] Needs Review
| @@ -1,3 +1,4 @@ | |||
| /** @ssr-ready **/ | |||
|
|
|||
| /* !!! | |||
| IF YOU ARE EDITING gridicon/index.jsx | |||
There was a problem hiding this comment.
Potentially OT, but is this warning still current?
There was a problem hiding this comment.
Yep, there's a PR in the Gridicons repo for this. 136-gh-gridicons
|
👍 |
1 similar comment
|
👍 |
|
So, I think if I merge this, it'll immediately cause everyone's |
ehg
force-pushed
the
update/mark-masterbar-ssr-ready
branch
from
e14d790 to
e3c6314
Compare
|
OK, I'm ignoring |
- Gridicons manually updated, but should merge fine. - Ignore config — for these situations where a module has different code for client/server, we shouldn't mark them as ssr-ready.
ehg
force-pushed
the
update/mark-masterbar-ssr-ready
branch
from
9422707 to
f7e7448
Compare
|
Can confirm. 👍 |
ehg
added a commit
that referenced
this pull request
Jan 15, 2016
SSR: Mark masterbar and layout files as `@ssr-ready`
ehg
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1551
Mark everything necessary to render the MasterBar on logged-out
/designas@ssr-ready. Gridicons manually updated for now.TODO:
shared/, see what we can mark as readyconfigTo test:
make run