Add stats to the global redux store #2310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblz
added
[Type] Enhancement
[Feature] Stats
jblz
force-pushed
the
add/stats-redux
branch
5 times, most recently
from
06f900e to
3a22aa2
Compare
|
|
||
| case 'searchterms': | ||
| summaryList = new StatsList( { siteID: siteId, statType: 'statsSearchTerms', period: activeFilter.period, date: endDate, max: 0, domain: site.slug } ); | ||
| fetchActions = createFetchActionsForModule( module, activeFilter, endDate, { post: queryOptions.post } ); |
There was a problem hiding this comment.
Check to see if this post param applies to both actions... I'm guessing not.
TODO: don't accept the extra params to createFetchActionsForModule & just explicitly modify the fetch actions here for exceptions.
jblz
force-pushed
the
add/stats-redux
branch
3 times, most recently
from
e2f98e8 to
e02f260
Compare
| const params = { | ||
| siteID, | ||
| statType, | ||
| options: { |
There was a problem hiding this comment.
If we pass postID here as well, we can automate this in getStatsItem & isStatsItemFetching.
Ideally, we wrap connect in our own util function statsConnect (or something) that handles this boilerplate for us in each component.
Initial commit includes a basic action & reducer to get started working with the store.
Now with selectable per-query states for response values & a composite-key-based `isLoading` value
… controller * Hooked up the individual post view (`StatsPostDetail`) to the redux flow by mapping redux state to component props * Removed usage of `StatsList` in `StatsPostDetail` & all child components * Use domain from the URL if the site id is not available * Block actions without a site id or domain (fixes #2400) * Break selectors and utils into their own files * Use deterministic composite keys instead of nested objects as store values
* Hook up most of the countryViews module tree * Generalize modules' connections between statTypes & fetchActions to their `moduleState` prop * Adapt `StatsDownloadCsv` & add util function: `csvData`
|
|
||
| export function getStatsItem( state, params ) { | ||
| const _params = normalizeParams( params ); | ||
| const key = getCompositeKey( _params ); |
There was a problem hiding this comment.
Note to self: try out the deterministic-stringify lib here.
|
This pull request will need to be updated with the merger of #3773:
|
|
Needs a refresh still. |
|
Closing since #5743 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User Stats State
A module for managing the data which backs a user or site's Stats reporting features.
Action Creators
createFetchActionsForModuleActions
fetchSiteStatsReducers
itemsfetchingItemsSelectors
getStatsItemisStatsItemFetchingUtils
getStatsTypesByModulegetCompositeKeynormalizeParamsisDefinedStill
@TODO:StatsList:StatsListThis is a work-in-progress and will be filled in as the implementation develops.