Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ssr-ready pragma check: fix module ignores #2474

Merged
merged 1 commit into from
Jan 15, 2016
Merged

Conversation

mcsf
Copy link
Member

@mcsf mcsf commented Jan 15, 2016

Previously, lines like

import decodeEntities from 'lib/formatting/decode-entities';

would yield

PragmaChecker: layout/head, dependency ./decode-entities is not /** @ssr-ready **/

thus revealing that the plugin is not using the full module path of the dependency to match it against the ignored modules.

/cc @ehg

@mcsf mcsf added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Server Side Rendering labels Jan 15, 2016
@mcsf mcsf self-assigned this Jan 15, 2016
@mcsf mcsf added this to the Themes: Showcase M3-LoggedOut milestone Jan 15, 2016
@ehg
Copy link
Member

ehg commented Jan 15, 2016

👍

mcsf added a commit that referenced this pull request Jan 15, 2016
@ssr-ready pragma check: fix module ignores
@mcsf mcsf merged commit b595036 into master Jan 15, 2016
@mcsf mcsf deleted the fix/pragma-checker-ignores branch January 15, 2016 17:54
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants