Post Editor: remove check for 'post' prop when rendering post formats accordion #25025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accordion The Post Format Accordion does its own check for null `post` or `siteId` and doesn't render anything in that case: it waits until the `postFormats` for the site and post type are fully known. There's no need to check the `post` prop in the `EditorDrawer` component. This patch removes that check, which is one of the last remaining usages of the Flux-based post object. I also do a little cleanup of the Post Formats Accordion, namely removing the `isLoading` prop. As the component doesn't render anything at all until all data are available, it's redundant. The prop is a leftover from earlier refactoring in #8593.
jsnajdr
added
[Feature] Post/Page Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Post Format Accordion does its own check for null
postorsiteIdand doesn't render anything in that case: it waits until thepostFormatsfor the site and post type are fully known.There's no need to check the
postprop in theEditorDrawercomponent. This patch removes that check, which is one of the last remaining usages of the Flux-based post object.I also do a little cleanup of the Post Formats Accordion, namely removing the
isLoadingprop. As the component doesn't render anything at all until all data are available, it's redundant. The prop is a leftover from earlier refactoring in #8593.How to test:
Verify that the Post Formats still work as expected: