Support User: Add Support User libraries (fix) #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordwest
added
[Status] Needs Review
|
I tested this and it worked as expected. If the only difference between this and the other PR that we got a 🚢 for is the file move, then let's go ahead and 🚢 this one too. |
dllh
added
[Status] Ready to Merge
and removed
[Status] Needs Review
4 tasks
jordwest
force-pushed
the
add/support-user-libs
branch
2 times, most recently
from
f1add50 to
b04e8ff
Compare
jordwest
force-pushed
the
add/support-user-libs
branch
from
b04e8ff to
5651e0f
Compare
jordwest
added a commit
that referenced
this pull request
Jan 18, 2016
Support User: Add Support User libraries (fix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a retry of #2368. The original PR broke staging by causing a 'module not found' error and was subsequently reverted in #2509. This was due to the
shareddirectory being removed in #2309.The only change in this PR is moving
/shared/lib/wp/support.jsto/client/lib/wp/support.js; otherwise it's the same as #2368.Lesson learned: Always rebase from master and test before merging, even if GitHub says the merge can be done cleanly.
Original PR (#2368)
This PR adds libraries that will be used in the support user functionality (ref p195om-2GO-p2)
An access token is granted when a support user and password are provided; the token can be revoked during a restore operation, or will expire after a set period of time. Once granted, the support username and token are passed along all queries to the API.
This is a subset of the original PR #1202 (props to @jmdodd), separated out for easier progressive review.