People: update the remove follower warning message #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #2672 This pull request seeks to clarify the warning notice that appears after you remove a follower more clear so that it doesn't give site owners a false sense of privacy. To test: 1. Go to https://wordpress.com/people/followers and select a blog if prompted 1. Click "Remove" next to one of the followers 1. Check that the wording in the message has been updated to say: ``` If you remove this follower, he or she will no longer receive notifications about this site unless they re-follow. ```
designsimply
added
[Status] Needs Review
|
I tested this change locally, and in English it looks good to me 👍 Dutch Before: Dutch After: English Before: English After |
|
Translations for updated strings are done through GlotPress and will typically happen at their own pace after an update like this. |
|
👍 Tested with Firefox 43.0.4 on OS X 10.11.2 on http://calypso.localhost:3000/people/followers/example.wordpress.com Wording appears as expected. |
|
|
ebinnion
added a commit
that referenced
this pull request
Jan 22, 2016
People: update the remove follower warning message
scruffian
removed
the
[Status] Needs Review
This was referenced Jan 19, 2020
This was referenced Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2672
This pull request seeks to clarify the warning notice that appears after you remove a follower more clear so that it doesn't give site owners a false sense of privacy.
To test: