Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Replace the default auto-draft title of new Gutenberg posts. #27297

Merged
merged 6 commits into from
Sep 20, 2018
Merged

Editor: Replace the default auto-draft title of new Gutenberg posts. #27297

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa7ebdd
Editor: Add the Gutenberg demo title to new Gutenberg posts.
kwight Sep 18, 2018
ce709b3
Allow translations for the title.
kwight Sep 19, 2018
23cbb21
Replace the default auto-draft title with "Add title" when creating new
kwight Sep 19, 2018
f4f3687
Gutenberg: use overridePost and editorSettings to set placeholder text
gwwar Sep 20, 2018
9b8052f
Only overrise the post title if we get back an auto-draft.
kwight Sep 20, 2018
a55ebe6
Move post override logic to `mapStateToProps`.
kwight Sep 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions client/gutenberg/editor/main.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@ import { requestGutenbergDraftPost as createAutoDraft, requestSitePost } from 's
import { getHttpData } from 'state/data-layer/http-data';
import { getSiteSlug } from 'state/sites/selectors';
import { WithAPIMiddleware } from './api-middleware/utils';

const editorSettings = {
autosaveInterval: 3, //interval to debounce autosaving events, in seconds.
};
import { translate } from 'i18n-calypso';

class GutenbergEditor extends Component {
componentDidMount() {
Expand All @@ -38,7 +35,14 @@ class GutenbergEditor extends Component {
}

render() {
const { postType, siteId, siteSlug, post } = this.props;
const { postType, siteId, siteSlug, post, overridePost } = this.props;

//see also https://github.com/WordPress/gutenberg/blob/45bc8e4991d408bca8e87cba868e0872f742230b/lib/client-assets.php#L1451
const editorSettings = {
autosaveInterval: 3, //interval to debounce autosaving events, in seconds.
titlePlaceholder: translate( 'Add title' ),
bodyPlaceholder: translate( 'Write your story' ),
};

return (
<WithAPIMiddleware siteSlug={ siteSlug }>
Expand All @@ -49,6 +53,7 @@ class GutenbergEditor extends Component {
hasFixedToolbar={ true }
post={ post }
onError={ noop }
overridePost={ overridePost }
/>
</WithAPIMiddleware>
);
Expand All @@ -67,10 +72,13 @@ const getPost = ( siteId, postId ) => {
const mapStateToProps = ( state, { siteId, postId, uniqueDraftKey } ) => {
const draftPostId = get( getHttpData( uniqueDraftKey ), 'data.ID', null );
const post = getPost( siteId, postId || draftPostId );
const isAutoDraft = 'auto-draft' === get( post, 'status', null );
const overridePost = isAutoDraft ? { title: '' } : null;

return {
siteSlug: getSiteSlug( state, siteId ),
post,
overridePost,
};
};

Expand Down