User: Fix bug where fetch error prevents any further attempts #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordwest
added
[Type] Bug
[Status] Needs Review
|
Looks good to me. I had a similar bug not too long ago with the importer. |
dmsnell
added
[Status] Ready to Merge
and removed
[Status] Needs Review
jordwest
force-pushed
the
fix/user-fetch-error-prevents-further-attempts
branch
from
e376ef6 to
b52320e
Compare
jordwest
added a commit
that referenced
this pull request
Jan 28, 2016
…s-further-attempts User: Fix bug where fetch error prevents any further attempts
|
This change broke signup for logged out users, because we assume that user.get() is falsey unless the user is logged in. We should still try to address this issue, but we need to ensure that we don't break signup next time. |
|
@drewblaisdell @scruffian Thanks for catching this one |
This was referenced Jan 19, 2020
This was referenced Oct 14, 2020
This was referenced Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Userobject has afetchingproperty used to avoid doubling up on fetch requests. Ifuser.fetchingistrue, any attempts to calluser.fetch()will be ignored. This PR fixes a bug wherethis.fetchingwas not being reset after a failed fetch.Before this change
user.fetch()is calleduser.fetch()is called again, but the attempt is ignoredAfter this change
user.fetch()is calleduser.fetch()is called again, the request is made as expected