Invites: Do not show sign up for match email error to known user

[roccotripaldi]

If an invite was sent to a known user, and the site requires that all
invites be accepted with a matching email, there's no need to show a signup form.

Closes #2767

Prior to this PR we'd present this for invites to known users:

But it doesn't make sense to ask a known user to sign up. So this PR will instead present this:

To test:

• Invite a known user to a blog that requires matching email addresses
• As a logged out user, visit the accept invite page in calypso.localhost:3000
• Ensure that the flow makes sense, and there are no errors
• Repeat for an invite to an unknown user

[roccotripaldi]

cc: @lezama and @ebinnion

[roccotripaldi]

@rickybanister mentions that an error notice is not needed in this case

[ebinnion]

Have you already addressed not showing the error notice for logged out invites to know users? I'm still seeing the notice, and can verify that the invite is to a known user since the button says, "Sign in as..."

[ebinnion]

Disregard, I was actually logged in 😞 Code wise, this looks good to me. Let's just get a design review from @rickybanister. Here are updated screenshots:

• Logged out match email error to a known user:

• Logged out match email error to an unknown user (note that the email input is disabled):

• Logged out no error:

[rickybanister]

The disabled email field still needs an italic note beneath it explaining why it's disabled/cannot be edited. Something like

The invitation can only be accepted by %email-address%

[ebinnion]

Screenshot for the italic note that @rickybanister suggested.

[ebinnion]

I believe we need a blank line above this.

[ebinnion]

I left a couple of comments about the no validate style. Besides that, this LGTM.

[rickybanister]

Perfect @roccotripaldi ! Now we're talking.

[roccotripaldi]

Addressed your feedback @ebinnion - thanks!

[ebinnion]

I noticed this error when going to a logged out invite to a known user. I'm looking into it now.

[roccotripaldi]

whoa, good catch

[ebinnion]

@roccotripaldi – I pushed up a commit that I believe fixes that error. In my testing, the issue seemed to be that we update state after getting an invite and then right after that we update state to set matchEmailError. Because of this slight time difference, there was a period where matchEmailError was false and the SignupForm would be rendered in invite-accept-logged-out.

My commit refactors the refreshEmailMatchError() to return a boolean which we then use in invite-accept.

I tested both logged in and logged out flows for forcing email, and I didn't notice any regressions. If you're fine with my changes, then

[roccotripaldi]

I was getting Uncaught TypeError: Cannot read property 'forceMatchingEmail' of undefined on you last commit. I amended it. should be good now.

[ebinnion]

Let's remove this.

[ebinnion]

@roccotripaldi - Thanks for fixing the error. I reviewed again and this LGTM.