-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for unlaunched private sites #27962
Conversation
75553dd
to
1bbfbcc
Compare
if ( this.props.isUnlaunchedSite ) { | ||
if ( this.props.needsVerification ) { | ||
return ( | ||
<EmailVerificationGate> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth setting a different notice text
8ec6349
to
fbca8d1
Compare
fbca8d1
to
1dd44dd
Compare
} = this.props; | ||
|
||
return ( | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL Fragment shorthand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine and tests properly according to your criteria, but I'm still wondering about the TODOs in a couple of places.
Looks like it's still supposed to get some site launching capability?
Yeah I'll add that in a new PR |
This PR lays the groundwork necessary for the "private by default" project. It works in combination with this server side patch: D19586-code.
There are more changes necessary to make it possible to launch the site from Calypso, but I wanted to keep this PR small.
Changes proposed in this Pull Request
site
step are created as Private. They are also set tounlaunched
.unlaunched
site, they are able publish content and import sites but they can't change their privacy settings.Testing instructions