remove 'bin/analyze-css.js' & deps #27979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flootr
added
the
[Status] Needs Review
matticbot
removed
the
[Status] Needs Review
flootr
added
the
[Status] Needs Review
flootr
force-pushed
the
remove/terminal-kit-dep
branch
from
47f2fb4 to
238ae94
Compare
matticbot
removed
the
[Status] Needs Review
jsnajdr
added a commit
that referenced
this pull request
Jan 19, 2020
Finishes the removal started in #27979.
jsnajdr
added a commit
that referenced
this pull request
Jan 22, 2020
Finishes the removal started in #27979.
jsnajdr
added a commit
that referenced
this pull request
Jan 27, 2020
* Remove the analyze-css NPM script Finishes the removal started in #27979. * Update clean scripts: paths of generated files, simplify how they are invoked Updates the paths of generated files to remove (`server/` to `client/server/`), use `run-s` to run all `clean:*` scripts at once. * Update path to stats.json file in whybundled script * Validate fallback build in a separate script Makes lines in `package.json` shorter 🙂 * Fix the NODE_ARGS argument in the start-build scripts `node NODE_ARGS=...` is an error that fails the script invocation: ``` Error: Cannot find module '/Users/jsnajdr/src/wp-desktop/calypso/NODE_ARGS=--max_old_space_size=8192' ``` We want to invoke `node` with `$NODE_ARGS` arguments and supply a default. * Eliminate the need for setting NODE_PATH when building or running Calypso It was needed only to `require` two specific files (webpack config for webpack dev server and search index for devdocs). Updated the webpack `externals` definition to remove that need. * Update path to stats.json file in analyze-bundles script * Consolidate setting max_old_space_size to the build-client scripts that runs webpack * Remove duplication from build-client and start-build tasks by using cross-env and a *-do subtask * Settle on PROGRESS=true as the truth marker * Remove cross-env-shell from start-build-do, as it doesn't set any env vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need this script anymore as we're incrementally shifting our CSS pipeline to Webpack which for itself will optimize and split our CSS files.
Changes proposed in this Pull Request
bin/analyze-css.jsand related dependenciesTesting instructions
related #27923