-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiled gallery: Use requestAnimationFrame for resize handling #29016
Conversation
This is an automated check which relies on Generated by 🚫 dangerJS |
width, | ||
} ); | ||
} | ||
function handleResize( entries ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really like to get all the resize handling using the same code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, that would be good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it! 😍
Sooo funny that we can use an existing bug to test this. 😆
🚢
Changes proposed in this Pull Request
requestAnimationFrame
for resize observer handlingTesting instructions
gutenpack-jn
This version should deliver significantly better results.
Demo
Before
https://cloudup.com/cRMQ6_H66kG
After
https://cloudup.com/cT8GLQdfFYL
Part of #28978