Tiled gallery: Use requestAnimationFrame for resize handling #29016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated check which relies on Generated by 🚫 dangerJS |
sirreal
added
[Type] Enhancement
Jetpack
[Status] Needs Review
sirreal
requested review from
MichaelArestad and
a team
and removed request for
simison
sirreal
commented
Dec 1, 2018
| width, | ||
| } ); | ||
| } | ||
| function handleResize( entries ) { |
There was a problem hiding this comment.
I would really like to get all the resize handling using the same code.
simison
approved these changes
Dec 3, 2018
simison
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
requestAnimationFramefor resize observer handlingTesting instructions
gutenpack-jn
This version should deliver significantly better results.
Demo
Before
https://cloudup.com/cRMQ6_H66kG
After
https://cloudup.com/cT8GLQdfFYL
Part of #28978