Themes: Move themes/helpers from lib/ to my-sites/ #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That file sure was getting lonely.
ockham
added
[Feature Group] Appearance & Themes
|
👍 |
ockham
added a commit
that referenced
this pull request
Feb 10, 2016
Themes: Move themes/helpers from lib/ to my-sites/
scruffian
removed
the
[Status] Needs Review
|
Mmm, we shouldn't have non-component files in "my sites" outside of routes and controllers. |
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That file sure was getting lonely.
No visual changes. To test -- verify that everything affected by this change works as before, i.e.
/design-- test thoroughly