Migrate CSS of PostTime and PostStatus blocks to CSS, plus a few tweaks #30963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was never visible anyway because of `showIcon=false` prop and `display: none` style. It was added a long time ago in #8679. You can see on the screenshots that the editor looked very differently back then. Then the editor was redesigned to the current look in #11536, where `PostStatus` was hidden, but not completely removed.
jsnajdr
added
[Status] Needs Review
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostTimeandPostStatusstyles to webpackconnect) inPostStatusdevdocs examplelocalizefromPostTime, as it doesn't usetranslate. UsewithLocalizedMomentto get themomentinstance.PostTimeFinally remove
PostStatususage fromEditorPostType. It was never visible anyway because ofshowIcon=falseprop anddisplay: nonestyle. It was added a long time ago in #8679. You can see on the screenshots that the editor looked very differently back then. Then the editor was redesigned to the current look in #11536, wherePostStatuswas hidden, but not completely removed..How to test:
PostTimeandPostStatusEditorPostTypebox in the Classic Editor UII hope the PR is not too big 😉