Export: Simplify state tree - remove Immutable.js #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordwest
added
Export
[Status] Needs Review
|
👍 Tested in Chrome, FF, Safari, IE 11, and Edge. |
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
jordwest
added a commit
that referenced
this pull request
Feb 5, 2016
…ucer-state Export: Simplify state tree - remove Immutable.js
|
Thanks for the super speedy response @gwwar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes Immutable.js objects from the Exporter, moving instead to plain JS objects. There should be no functionality changes.
This change was prompted for a few reasons:
Testing:
/settings/export, click the Export All button. Ensure a success message is displayed.(cd client/state/site-settings/exporter && make test)ensuring tests passcc @dllh @aduth @dmsnell