Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostShare block maintenance: localize, CSS migration and fixes, ESLint a11y fix #31022

Merged
merged 4 commits into from
Feb 26, 2019

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Feb 26, 2019

Clean up usage of i18n-calypso
The ConnectionsList component doesn't use anything from the localize wrapper, which is therefore removed.
On the other hand, NoConnectionsNotice gets wrapped by localize and doesn't need to be passed the translate prop from the parent. It also gets its own file.

Migrate CSS styles to webpack
Fairly straighforward, no complications.

Fix some CSS glitches in NoConnectionsNotice
Before: notice the useless margin under the notice and unwanted border radius on the left:
screenshot 2019-02-26 at 13 21 33

After: both glitches get fixed:
screenshot 2019-02-26 at 13 35 37

Remove an ESLint-offending tabIndex prop from CalendarButton
The component ignores the prop anyway, so it's an easy win. Verify that tab navigation around the share block works as expected (after you connect a social account):

screenshot 2019-02-26 at 13 45 23

@jsnajdr jsnajdr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial Publicize labels Feb 26, 2019
@jsnajdr jsnajdr self-assigned this Feb 26, 2019
@matticbot
Copy link
Contributor

@jsnajdr jsnajdr requested review from sgomes and a team February 26, 2019 13:02
Copy link
Contributor

@sgomes sgomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, and the test branch appears to work correctly.

Good work splitting out NoConnectionsNotice to facilitate code splitting! 👍

@jsnajdr jsnajdr merged commit ef27a32 into master Feb 26, 2019
@jsnajdr jsnajdr deleted the migrate/post-share-moment-and-styles branch February 26, 2019 15:14
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants