Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat Visitor: add additional block keywords #31060

Closed
wants to merge 1 commit into from

Conversation

bluefuton
Copy link
Contributor

@bluefuton bluefuton commented Feb 27, 2019

Changes proposed in this Pull Request

Based on feedback in our internal call for testing (p1HpG7-6k7-p2), this PR adds additional keywords to help new users discover the Repeat Visitor block.

Testing instructions

Spin up a Jurassic Ninja instance.

Connect Jetpack to your WPCOM account.

Navigate to Settings->Jetpack Constants, check JETPACK_BETA_BLOCKS, and Save.

Navigate to the post editor and click + to add a new block. Try searching for a block with the following terms and make sure that Repeat Visitor is suggested:

  • visitor
  • hidden
  • conditional

@bluefuton bluefuton added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg labels Feb 27, 2019
@bluefuton bluefuton self-assigned this Feb 27, 2019
@matticbot
Copy link
Contributor

@bluefuton bluefuton requested a review from jsnmoon February 27, 2019 01:33
@bluefuton
Copy link
Contributor Author

bluefuton commented Feb 27, 2019

This relies on WordPress/gutenberg#13848 which was committed recently but does not appear to have been released yet. It removes the previous 3-keyword restriction on block keywords:

screen shot 2019-02-27 at 14 42 53

@bluefuton bluefuton added [Status] Blocked / Hold and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 27, 2019
Copy link
Contributor

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relies on WordPress/gutenberg#13848

Bummer. This is good to go whenever appropriate.

@bluefuton
Copy link
Contributor Author

This is good to go whenever appropriate.

Thanks! Exceeding 3 keyword limit actually prevents the block from showing up at all :/ So I'll hold off shipping it until that's resolved.

@bluefuton
Copy link
Contributor Author

bluefuton commented Mar 28, 2019

@beaulebens also suggested "return" as a keyword during testing: p8oabR-lg-p2 / #11749

@simison
Copy link
Member

simison commented Mar 28, 2019

WordPress/gutenberg#13848 only removes the error stopping the block from functioning, but the limit still holds. Gutenberg will ignore more than 3 keywords and there are no plans to remove that limitation:

Instead of failing to register a block if more than 3 keywords are given, only return the first 3 by slicing the keywords array.

@bluefuton
Copy link
Contributor Author

Thanks for clarifying, @simison. I'll close this one.

@bluefuton bluefuton closed this Mar 28, 2019
@bluefuton bluefuton deleted the update/repeat-visitor-keywords branch March 28, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Status] Blocked / Hold [Status] Needs Rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants