-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeat Visitor: add additional block keywords #31060
Conversation
This relies on WordPress/gutenberg#13848 which was committed recently but does not appear to have been released yet. It removes the previous 3-keyword restriction on block keywords: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This relies on WordPress/gutenberg#13848
Bummer. This is good to go whenever appropriate.
Thanks! Exceeding 3 keyword limit actually prevents the block from showing up at all :/ So I'll hold off shipping it until that's resolved. |
@beaulebens also suggested "return" as a keyword during testing: p8oabR-lg-p2 / #11749 |
WordPress/gutenberg#13848 only removes the error stopping the block from functioning, but the limit still holds. Gutenberg will ignore more than 3 keywords and there are no plans to remove that limitation:
|
Thanks for clarifying, @simison. I'll close this one. |
Changes proposed in this Pull Request
Based on feedback in our internal call for testing (p1HpG7-6k7-p2), this PR adds additional keywords to help new users discover the Repeat Visitor block.
Testing instructions
Spin up a Jurassic Ninja instance.
Connect Jetpack to your WPCOM account.
Navigate to Settings->Jetpack Constants, check JETPACK_BETA_BLOCKS, and Save.
Navigate to the post editor and click + to add a new block. Try searching for a block with the following terms and make sure that Repeat Visitor is suggested: