Remove Plugins page for non-Jetpack sites (cleanup of #3079) #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tug
added
[Status] In Progress
Jetpack Plugins
[Type] Janitorial
[Feature] Checkout
Tug
changed the title
Tug
force-pushed
the
remove/plugins-page-wpcom
branch
from
da5050a to
a4da13c
Compare
This makes it more consistent with the logic to display the Plan menu item.
This clarifies the code by minimizing the number of feature gates.
This also switches part of a condition to make it easier to understand.
This make sure the Plugins page is not accessible from the sidebar for sites with a Business plan and ecommerce plugins.
Tug
force-pushed
the
remove/plugins-page-wpcom
branch
from
a4da13c to
1c031c0
Compare
Tug
force-pushed
the
remove/plugins-page-wpcom
branch
from
1c031c0 to
414f035
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of removing the eCommerce feature from the Business plan upgrade, the plugins page becomes available to Jetpack sites only. The "Plugins" menu entry is being removed on #3079
This PR removes references to plugins related to Business upgrade and redirects
/plugins/:siteto/pluginsif the current site is not a jetpack.