Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

People: Remove debug UI from invite form #3195

Merged
merged 1 commit into from
Feb 10, 2016
Merged

People: Remove debug UI from invite form #3195

merged 1 commit into from
Feb 10, 2016

Conversation

ebinnion
Copy link
Contributor

@ebinnion ebinnion commented Feb 9, 2016

Previously, we were stringifying the response returned from sending an invite and displaying that in a card on the invite page. This seemed fine at the time. But, as we get closer to shipping invites, let's use debug() instead.

To test:

  • Checkout update/people-invite-debug-code branch
  • Go to /people/new/$site
  • Enter localStorage.setItem( 'debug', 'calypso:my-sites:people:invite' )
  • Send an invite
  • Ensure that response is logged in console

cc @lezama for review

@ebinnion
People: Remove debug UI from invite form
0fede83 
Previously, we were stringifying the response returned from sending an invite and displaying that in a card on the invite page. This seemed fine at the time. But, as we get closer to shipping invites, let's use debug() instead.
@ebinnion ebinnion added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. People Management labels Feb 9, 2016
@ebinnion ebinnion self-assigned this Feb 9, 2016
@ebinnion ebinnion added this to the People Management: m7 milestone Feb 9, 2016
@ebinnion ebinnion mentioned this pull request Feb 9, 2016
Merged
lezama added a commit that referenced this pull request Feb 10, 2016
@lezama
Merge pull request #3195 from Automattic/update/people-invite-debug-code
fd0cb19 
People: Remove debug UI from invite form
@lezama lezama merged commit fd0cb19 into master Feb 10, 2016
@lezama lezama deleted the update/people-invite-debug-code branch February 10, 2016 12:13
@scruffian scruffian removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 10, 2016
This was referenced Dec 7, 2021
Open
Open
Open
Open
Open
Open
@mayuba mayuba mentioned this pull request May 13, 2022
Open
@mdno mdno mentioned this pull request May 14, 2022
Open
@anarh anarh mentioned this pull request May 14, 2022
Open
@apmarshall apmarshall mentioned this pull request May 14, 2022
Open
@ajesse11x ajesse11x mentioned this pull request May 14, 2022
Open
@awaisab172 awaisab172 mentioned this pull request May 14, 2022
Open
@mayuba mayuba mentioned this pull request Sep 8, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Sep 8, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 8, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Sep 8, 2022
Open
@apmarshall apmarshall mentioned this pull request Sep 9, 2022
Open
@anarh anarh mentioned this pull request Oct 26, 2022
Open
@mdno mdno mentioned this pull request Oct 26, 2022
Open
@mdno mdno mentioned this pull request May 25, 2023
Open
@anarh anarh mentioned this pull request Nov 28, 2023
Open
@mdno mdno mentioned this pull request Nov 28, 2023
Open
@mayuba mayuba mentioned this pull request Nov 28, 2023
Open
@apmarshall apmarshall mentioned this pull request Nov 28, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 29, 2023
Open
@awaisab172 awaisab172 mentioned this pull request Nov 30, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ebinnion ebinnion

Labels
People Management
Projects
None yet
Milestone
People Management: m7
Development

Successfully merging this pull request may close these issues.
3 participants
@ebinnion @lezama @scruffian