Validate .tld for new feed URLs #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowery
added
[Status] Needs Author Reply
[Feature] Reader
|
@artpi had concerns over using the parse-domain library, because it has this list hard-coded: We could perhaps swap it out for a simple check if looks like a .tld (i.e. a dot and at least 2 characters at the end of the string). |
bluefuton
force-pushed
the
fix/reader-following-management-tld-validation
branch
from
73d245c to
973657d
Compare
bluefuton
added
[Status] Needs Review
|
cc @aerych |
| } | ||
|
|
||
| return false; | ||
| // Check for a valid-looking TLD | ||
| const lastHostnameSegment = last( parsedUrl.hostname.split( '.' ) ); |
There was a problem hiding this comment.
i think this is fine, but you could also use lastIndexOf, compare that to length - 2 (3?), and avoid the allocations that come with split.
There was a problem hiding this comment.
Thanks, I like that. Changing now.
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
|
bluefuton
added a commit
that referenced
this pull request
Nov 25, 2015
…nt-tld-validation Validate .tld for new feed URLs
This was referenced Nov 17, 2020
This was referenced Apr 13, 2021
This was referenced Apr 26, 2021
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that new feed URLs have a valid .tld before allowing the user to follow the feed.
Fixes #96.