Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Update the icon we use for domains in the sidebar #3320

Merged
merged 1 commit into from
Feb 16, 2016

Conversation

breezyskies
Copy link
Contributor

When we launched the domain sidebar item, globe was being used for the "view site" link. That item has now been incorporated into the site card, so this PR updates the "domains" sidebar item to use the globe icon instead of cart (since this section includes domain management, not just purchases).

Before After
screen shot 2016-02-15 at 1 26 03 pm screen shot 2016-02-15 at 1 25 37 pm

@breezyskies breezyskies added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Sidebar [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Feb 15, 2016
@breezyskies breezyskies self-assigned this Feb 15, 2016
@rickybanister
Copy link

Looks right to me.

@stephanethomas
Copy link
Contributor

Code looks good.

@stephanethomas stephanethomas added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 16, 2016
@mtias
Copy link
Member

mtias commented Feb 16, 2016

We use globes for default site-icons as well. It'd be good to have a more specific one for domains, but this seems good for now.

@folletto
Copy link
Contributor

I think this is a good iteration up. :)

Would be even better in my view to make a new icon to Gridicons that is something like a globe with an overlaid URL/address field on top of it (signifying globe + address). :)

@breezyskies
Copy link
Contributor Author

Would be even better in my view to make a new icon to Gridicons that is something like a globe with an overlaid URL/address field on top of it (signifying globe + address). :)

Agreed, although as @mikeshelton1503 pointed out when we were looking at this, it's going to be hard to do this in a readable way at this size. Something to think about and iterate on in the near future. :)

breezyskies added a commit that referenced this pull request Feb 16, 2016
Domains: Update the icon we use for domains in the sidebar
@breezyskies breezyskies merged commit 580f8ac into master Feb 16, 2016
@breezyskies breezyskies deleted the update/domains-sidebar-icon branch February 16, 2016 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants