Framework: Start catching js errors in production #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
Framework
[Status] Needs Review
|
Code looks good. |
|
Should this work in development mode? I'm testing this and getting not found error. |
|
@lamosty - good catch, thanks. We don't want to load this file in development :) |
scruffian
force-pushed
the
update/catch-js-errors
branch
from
3acddd1 to
f6100b1
Compare
|
👍 now that dev is excluded. :) |
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
scruffian
added a commit
that referenced
this pull request
Feb 23, 2016
Framework: Start catching js errors in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the error catching thing has been running OK in staging we should push it out to production so it's actually useful :)