Added redux store to full-post & refactored it to use redux ui state #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelclemens
force-pushed
the
add/redux-fullpost
branch
from
af19d5c to
b3fc6e4
Compare
| @@ -374,7 +377,7 @@ FullPostContainer = React.createClass( { | |||
| mixins: [ PureRenderMixin ], | |||
|
|
|||
| getInitialState: function() { | |||
| return assign( { isVisible: false }, this.getStateFromStores() ); | |||
| return assign( {}, this.getStateFromStores() ); | |||
There was a problem hiding this comment.
Don't even need the assign now
There was a problem hiding this comment.
Addressed that, thanks.
Made 2 actions instead of 1 for showing/hiding the post Switcher proccess.nextTick for lodash's defer
|
Looks great, merging! |
blowery
added a commit
that referenced
this pull request
Feb 20, 2016
Added redux store to full-post & refactored it to use redux ui state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made sure redux store is passed down to full post, similar to how it was done for sidebar.
The side-effect of this was the need to refactor the
setState( { isVisibile: true } )calls on the component.It's now handled via redux.
This replaces #2932