Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: remove nested anchor in theme sheet #34695

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Theme: remove nested anchor in theme sheet #34695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61f2f32
remove nested anchor
donpark Jul 16, 2019
706aaab
use div to avoid nested anchor warning
donpark Jul 18, 2019
06dfc7c
tweak gradient to let more screenshot through
donpark Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions client/my-sites/theme/main.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,21 +228,18 @@ class ThemeSheet extends React.Component {
return demo_uri && ! retired;
}

// Render "Open Live Demo" pseudo-button for mobiles.
// This is a legacy hack that shows the button under the preview screenshot for mobiles
// but not for desktop (becomes hidden behind the screenshot).
renderPreviewButton() {
return (
<a
className="theme__sheet-preview-link"
onClick={ this.previewAction }
data-tip-target="theme-sheet-preview"
href={ this.props.demo_uri }
rel="noopener noreferrer"
>
<div className="theme__sheet-preview-link" data-tip-target="theme-sheet-preview">
<span className="theme__sheet-preview-link-text">
{ i18n.translate( 'Open Live Demo', {
context: 'Individual theme live preview button',
} ) }
</span>
</a>
</div>
);
}

Expand Down
2 changes: 1 addition & 1 deletion client/my-sites/theme/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
height: 30%;
background: linear-gradient(
to bottom,
rgba( var( --color-neutral-0-rgb ), 1 ) 0%,
transparent 0,
rgba( var( --color-neutral-0-rgb ), 0.5 ) 40%,
var( --color-neutral-0 ) 93%
);
Expand Down