-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ribbon: Move to calypso-ui #35768
Ribbon: Move to calypso-ui #35768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~184 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~139 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~821 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Ah, my bad. They had been there for about ~2 years to indicate certain classes of themes, e.g. 'Beginner'.
Yay!
Ah, good spot. That's probably due to the way we import the respective components directly (from I just noticed that the devdocs example for |
11e6ca4
to
2329e0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seems to work fine 🚢
This is a leaf component that doesn't have any counterpart in
@wordpress/components
. It might come in handy in Jetpack (to highlight paid Gutenberg blocks in the block picker).Changes proposed in this Pull Request
Ribbon: Move to calypso-ui
Testing instructions
Verify that the ribbon still works: