-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Move CONTRIBUTING.md to docs/ #36167
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~3 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
1dd8cb6
to
8e3fd6b
Compare
8e3fd6b
to
bf05135
Compare
Any objections or gotchas, @Automattic/team-calypso? Looks sane to me. |
Needs a rebase, but other than that LGTM 👍 Will take over to land it, as Bernie is AFK these days. |
bf05135
to
5cc6c62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks! Going to 🚢 it.
Changes proposed in this Pull Request
CONTRIBUTING.md
from.github/
todocs/
The motivation for this is #35833 -- to enable webpack loaders to find this file (in a non-hidden directory).
GitHub should continue to be able to find this file:
(Source)
Testing instructions
calypso.localhost:3000/devdocs
, and click on "Contributing" in the sidebar. Verify that the link still works..github/CONTRIBUTING.md
.