Checkout: Thank You: Use ES6 imports/export/identifiers/functions #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewblaisdell
added
[Type] Enhancement
[Status] Needs Review
drewblaisdell
force-pushed
the
update/thank-you-es6
branch
from
2a8aee3 to
553283f
Compare
scruffian
force-pushed
the
update/thank-you-es6
branch
3 times, most recently
from
54bf92e to
e0d4c03
Compare
This change is necessary because: - It fixes a linting error. - `findPurchaseAndDomain` only needs to be declared once.
scruffian
force-pushed
the
update/thank-you-es6
branch
from
e0d4c03 to
84d3397
Compare
|
LGTM 👍 |
scruffian
added
[Status] Ready to Merge
and removed
[Status] Needs Review
scruffian
added a commit
that referenced
this pull request
Mar 1, 2016
Checkout: Thank You: Use ES6 imports/export/identifiers/functions
This was referenced Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
CheckoutThankYouto use the ES6 syntax. Much of the work for this was already done by @stephanethomas and @scruffian, so these changes are pretty simple.Testing
There are no visual/behavioral changes to this component, so a code review that asserts that the behavior of the logic on the right is equal to that on the left should be sufficient. We should still assert that the thank you page loads properly after purchasing an item, but I haven't added a "Product Review" checkbox for this reason. @fabianapsimoes please correct me if I should still add this.