Domain Search: A/B test for the placeholder text and examples for the domains search field #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breezyskies
added
[Status] Needs Review
| @@ -166,6 +166,12 @@ var RegisterDomainStep = React.createClass( { | |||
| }, | |||
|
|
|||
| searchForm: function() { | |||
| var placeholderText = this.translate( 'Enter a domain or keyword', { textOnly: true } ); | |||
There was a problem hiding this comment.
You can get rid of all these { textOnly: true } parameters - they are not needed any more.
There was a problem hiding this comment.
Removed in c0981a2.
breezyskies
changed the title
| exampleDomains = ''; | ||
|
|
||
| if ( ! this.props.isInSigup && abtest( 'domainSearchPlaceholderText' ) === 'searchForADomain' ) { | ||
| placeholderText = this.translate( 'Search for a domain' ); |
There was a problem hiding this comment.
This test is currently limited to users with an en locale, so I don't think we should translate this string or "e.g." below.
|
I tested this and had one comment about the code, but otherwise, LGTM. |
breezyskies
force-pushed
the
add/domain-search-placeholder-test
branch
from
c9410f1 to
1a5c217
Compare
|
@drewblaisdell Removed the translation, updated the start date, and rebased. |
breezyskies
force-pushed
the
add/domain-search-placeholder-test
branch
from
1a5c217 to
7cb4427
Compare
|
LGTM. 👍 |
drewblaisdell
added
[Status] Ready to Merge
and removed
[Status] Needs Review
added 6 commits
March 4, 2016 06:14
…p domain searches.
breezyskies
force-pushed
the
add/domain-search-placeholder-test
branch
from
7cb4427 to
e19014d
Compare
breezyskies
added a commit
that referenced
this pull request
Mar 4, 2016
…r-test Domain Search: A/B test for the placeholder text and examples for the domains search field
2 tasks
This was referenced Mar 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new A/B test for showing different placeholder text and examples for the domain search field.
original:searchForADomain:To test:
localStorage.setItem( 'ABTests', '{"domainSearchPlaceholderText_20160302":"original"}' );localStorage.setItem( 'ABTests', '{"domainSearchPlaceholderText_20160302":"searchForADomain"}' );Note that this is only shown at
/domains/addand not in signup (since the goal is to increase domain searches and the signup step requires a search even if you are just opting for the*.wordpress.comdomain).