Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg 6.9.0 / CoBlocks 1.17.1: Placeholder PR for running E2E tests against Horizon #37361

Closed
wants to merge 0 commits into from
Closed

Gutenberg 6.9.0 / CoBlocks 1.17.1: Placeholder PR for running E2E tests against Horizon #37361

wants to merge 0 commits into from

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Nov 6, 2019 •
edited
Loading

DO NOT MERGE

Placeholder PR for running E2E tests checking new Gutenberg and Coblocks versions against Horizon

@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing horizon Run e2e tests against horizon env labels Nov 6, 2019
@mmtr mmtr requested a review from a team November 6, 2019 16:27
@mmtr mmtr self-assigned this Nov 6, 2019
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/gutenberg-6.9.0-e2e

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@gwwar gwwar mentioned this pull request Nov 6, 2019
Closed
10 tasks
@jeraldjuice jeraldjuice added [Status] Needs e2e Testing horizon Run e2e tests against horizon env and removed [Status] Needs e2e Testing horizon Run e2e tests against horizon env labels Nov 12, 2019
@mmtr mmtr changed the title Gutenberg 6.9.0: Placeholder PR for running E2E tests against Horizon Gutenberg 6.9.0 / CoBlocks 1.17.1: Placeholder PR for running E2E tests against Horizon Nov 13, 2019
@mmtr mmtr mentioned this pull request Nov 13, 2019
Closed
8 tasks
@mmtr mmtr added [Status] Needs e2e Testing horizon Run e2e tests against horizon env and removed [Status] Needs e2e Testing horizon Run e2e tests against horizon env labels Nov 13, 2019
@mmtr mmtr closed this Nov 14, 2019
@mmtr mmtr deleted the update/gutenberg-6.9.0-e2e branch November 14, 2019 14:58
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 14, 2019
@mmtr mmtr restored the update/gutenberg-6.9.0-e2e branch November 14, 2019 14:58
@mmtr
Copy link
Member Author

mmtr commented Nov 14, 2019

Interesting, a rebase automatically closes the PR when there are no commits to push 🤔

@mmtr mmtr reopened this Nov 14, 2019
@mmtr
Copy link
Member Author

mmtr commented Nov 14, 2019 •
edited
Loading

There are some failing sign up E2E tests unrelated to the Gutenberg upgrade. I thought we were not running them on Horizon, but maybe that has changed due to p4TIVU-9k4-p2? cc @bsessions85 @Stojdza

@bsessions85
Copy link
Contributor

@mmtr It looks like we had some new tests added that aren't excluded on Horizon. I'll get those changed.

@bsessions85
Copy link
Contributor

actually, those already have the excluded piece like the other tests, it is just failing because of a recent change. It is unrelated.

@kwight
Copy link
Contributor

kwight commented Nov 15, 2019

Re-running for CoBlocks 1.17.1-wpcom.

@kwight kwight added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing horizon Run e2e tests against horizon env and removed [Status] Needs e2e Testing horizon Run e2e tests against horizon env labels Nov 15, 2019
@kwight kwight closed this Nov 15, 2019
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 15, 2019
@kwight
Copy link
Contributor

kwight commented Nov 15, 2019

Wut. Force-pushing a rebase merged and closed this PR 🙃

@mmtr mmtr deleted the update/gutenberg-6.9.0-e2e branch February 26, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mmtr mmtr

Labels
DO NOT MERGE [Status] Needs e2e Testing horizon Run e2e tests against horizon env
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmtr @matticbot @bsessions85 @kwight @jeraldjuice