Signup: Update Default Themes in Signup #3738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamtakashi
added
[Feature Group] Appearance & Themes
See #2052 -- when a user doesn't have Jetpack enabled but tries to view themes for a Jetpack site of theirs, this is used for a preview of what the Themes section would look like.
I think it's not particularly urgent, but it might make sense. |
|
Thanks for the info! OK, they are not interactive elements so I think it's safe to update them to match with the new selection. |
iamtakashi
force-pushed
the
update/default-themes
branch
from
4a906a1 to
9900419
Compare
|
LGTM, but let's give it a few hours to get feedback from anyone running tests that might be affected. |
|
👍 |
drewblaisdell
added
[Status] Ready to Merge
and removed
[Status] Needs Review
iamtakashi
added a commit
that referenced
this pull request
Mar 3, 2016
Signup: Update Default Themes in Signup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent A/B test #3284 showed us that the new selection didn't negatively impact the conversion, therefore there is no reason to not to update with more modern and solid themes.
Since this is going to be the default, all flows that use
themestep as it is will affect by this update. So, if this is a concern for your tests currently running, please let me know.I have a question though. The current default themes are also listed in
/client/my-sites/themes/jetpack-manage-disabled-message.jsxI'm not familiar with what it does, do we also need to update it?New Selection
