Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People: Set maxLength of invitees to 10 #3739

Merged
merged 2 commits into from
Mar 3, 2016

Conversation

ebinnion
Copy link
Contributor

@ebinnion ebinnion commented Mar 2, 2016

Closes #3615

Adds a maxLength prop to TokenField and sets the maxLength of invitees to 10.

To test:

  • Checkout update/token-field-add-max-length branch
  • Go to /people/new/$site where $site is a WP.com site
  • Attempt to enter more than 10 invitees
  • You should only be able to enter 10
  • Remove a token by clicking the "x"
  • Now you should be able to add another token

cc @lezama for review

@ebinnion ebinnion added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. People Management labels Mar 2, 2016
@ebinnion ebinnion self-assigned this Mar 2, 2016
@ebinnion ebinnion added this to the People Management: m7 milestone Mar 2, 2016
@lezama
Copy link
Contributor

lezama commented Mar 2, 2016

works as described :)

🚢

@lezama lezama added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 2, 2016
ebinnion added a commit that referenced this pull request Mar 3, 2016
…ength

People: Set maxLength of invitees to 10
@ebinnion ebinnion merged commit 99c0a44 into master Mar 3, 2016
@ebinnion ebinnion deleted the update/token-field-add-max-length branch March 3, 2016 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants