-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blocks: Introduce a ProductPlanOverlapNotices block #37513
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~36 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Async-loaded Components (~565 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the code and left a couple of minor comments. I'm going to test it locally next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested locally and while I'm seeing the notification when I'm owning the Real-Time option, there is no message displayed if I have the Daily Backup in conjunction with Jetpack Personal or Premium plan.
@tyxla could you double check if those combinations work for you or is it some issue on my end only?
@delawski thanks for testing - the problem here is not related with my code; it's coming from the WP.com store - it doesn't allow having a Personal or Premium plan together with the Daily backup product. If you try purchasing one of them while having the other, the existing plan or product will get automatically canceled in favor of the new plan or product. Take a look at your purchases page or your SA and you will notice that you only have a single product or plan. AFAIK, this is something that @Automattic/chronos are aware of (cc @seear and @rcoll), but I'm not sure if it's actively being worked on. Since the logic in the code is generic, it should work for other cases like this, as long as the store allows it and the purchases endpoint returns both a plan and a product purchase. If you really want to test it, you can force the Let me know how that goes, but I'd really love to push this forward if it works for cases that the store currently supports. |
Issue is not related with this PR and with Calypso in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyxla Thank you for explaining where the issue I noticed come from! In this case I think this is good to go! Let's 🚢
While tested this and I found that when a site has the daily backup and the professional plan we don't show the notice at all in this case. I am not sure if this should be addressed in a different PR or this one? |
I think it's just a different type of overlap, but we can address it in a subsequent PR. I'll ship. Thank you guys 💪 |
Changes proposed in this Pull Request
Preview
Testing instructions