Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composite-checkout: Replace styled-components with emotion #37526

Merged
merged 4 commits into from
Nov 12, 2019

Conversation

sirbrillig
Copy link
Member

Changes proposed in this Pull Request

Mirroring the decision in WordPress/gutenberg#17963, we're going to swap out styled-components with emotion.

Testing instructions

  • Add a file called packages/composite-checkout/demo/private.js and inside it put the following: export const stripeKey = 'TEST KEY HERE';
  • Run npm run composite-checkout-demo.
  • Verify that the form works as expected.

@sirbrillig sirbrillig requested a review from a team as a code owner November 12, 2019 18:00
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirbrillig sirbrillig merged commit cdb3bcc into master Nov 12, 2019
@sirbrillig sirbrillig deleted the update/composite-checkout-emotion branch November 12, 2019 20:31
@bluefuton bluefuton added the [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants