Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SharingButtonsPreviewButton: add forwardRef flag to connect to make the button reffable #37570

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Nov 13, 2019

Fixes #37562, a regression introduced by the react-redux upgrade in #37438.

A connected component is used with a ref, and it needs to forward it to the inner component.

@jsnajdr jsnajdr added [Type] Bug [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 13, 2019
@jsnajdr jsnajdr requested a review from a team November 13, 2019 18:23
@jsnajdr jsnajdr self-assigned this Nov 13, 2019
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~15 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
marketing        +26 B  (+0.0%)      +15 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@blowery blowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

@jsnajdr jsnajdr merged commit 35fdd8d into master Nov 13, 2019
@jsnajdr jsnajdr deleted the fix/sharing-preview-button-ref branch November 13, 2019 19:06
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit/Add More Sharing Buttons goes to blank page
3 participants