State: Global test runner cleanup #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Framework
[Status] Needs Review
I think I needed the window object in one of the earlier revisions |
|
|
||
| before( () => { | ||
| domEnvSetup(); | ||
| createReduxStore = require( '../' ).createReduxStore; |
There was a problem hiding this comment.
👍 Nice that this turned into a simple import, I had trouble with some of the redux middleware previously
|
|
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
gziolo
added a commit
that referenced
this pull request
Mar 5, 2016
State: Global test runner cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3773
This pull request seeks to:
uiaccidentally importingusers)createReduxStoretestsconsole.errordirectly increateReduxStoretestsTesting instructions:
Ensure tests pass by running
make test