Build: upgrade mini-css-extract-plugin-with-rtl to npm-published a8c fork

[jsnajdr]

Updated the mini-css-extract-plugin-with-rtl package as follows:

• in https://github.com/Automattic/mini-css-extract-plugin-with-rtl, diverge from the original fork repo (https://github.com/beshanoe/mini-css-extract-plugin-with-rtl). I reused their code changes, but applied them as a different commit set on top of the mini-css-extract-plugin. The original fork repo uses a rather chaotic set of patch and merge commits that's difficult to rebase and maintain.
• apply the patch set to the v0.8.0 version of mini-css-extract-plugin
• release to npm as @automattic/mini-css-extract-plugin-with-rtl@0.8.0

Then I updated the calypso-build package to use the npm-published package.

Because version 0.8.0 introduced a new ignoreOrder option that allows to disable the conflicting order warnings, we no longer need to disable them ourselves with webpack-filter-warnings-plugin and can remove that code and the filter-warnings plugin, too, as this was its only usage.

Then I also updated the lockfiles of apps/full-site-editing and apps/wpcom-block-editor. full-site-editing referenced npm-published @automattic/calypso-build, so I changed that to a file: reference: makes more sense for monorepo.

How to test:
Build and run Calypso with ?flags=quick-language-switcher. Verify that when switching between LTR and RTL languages, the CSS chunks are switched at runtime.

[matticbot]

Test live: https://calypso.live/?branch=upgrade/mini-css-extract-plugin-with-rtl

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[jsnajdr]

@blowery I'm unable to update the apps/full-site-editing and apps/wpcom-block-editor lockfiles, no matter what I do.

Even if I remove the root node_modules and try to npm i in apps/full-site-editing from clean slate (no node_modules and package-lock.json), I get to a broken state.

• npm i succeeds and produces a local node_modules and package-lock.json
• it also produces a packages/calypso-build/node_modules directory
• when I run npm ci after this, it fails with @automattic/mini-css-extract-plugin-with-rtl not accessible from @automattic/calypso-build

It seems that referencing packages outside the current NPM root, e.g., file:../../packages/calypso-build, fails to treat all these directories as one tree and produce a valid package-lock.json.

Apparently, you were able to produce valid lockfiles in one of earlier version of this PR. How did you do that? 🙂

[jsnajdr]

The version of this patch currently in this branch has all the package-lock.json files removed. So that it's easier to experiment and rebase.

That's also why the CI tasks completely fail.

[blowery]

@jsnajdr here's some things to try:

# start from the root of calypso
npm run distclean;
cd apps/full-site-editing;
npm i;
# take a peek at the diff, stage the change
git add package-lock.json
npm ci; # this worked for me...
npm i; # you'd expect this to be a no-op... but...
git diff; # it wasn't for me
npm ci; #still worked, but different lock

[jsnajdr]

npm ci; # this worked for me...

This is the step where I'm failing. An important point is that I changed the reference to @automattic/calypso-build in apps/full-site-editing/package.json from npm reference (version number, downloaded the package from npm) to a file:../../packages/... reference.

Then the lockfile doesn't contain any calypso-build dependencies, probably because they are installed into packages/calypso-build/node_modules, which is outside the apps/full-site-editing subtree. I assume that npm dedupe and the lockfile generation code has some issue with that.

[blowery]

What version of npm? Does npm@latest behave any differently?

[jsnajdr]

I'm on npm 6.9.0, the one that ships with the current Node LTS. Nothing special.

[blowery]

@jsnajdr redid the locks here with npm@6.13.2 and had to run npm i twice in the root to get the right bits to appear in the root lockfile.

[jsnajdr]

@blowery after rebasing on top of #38190, this upgrade becomes trivial 👍 Please 👀

[blowery]

LGTM! Tested out well.