Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration tests after the client/ monorepo reshuffling #38902

Merged
merged 3 commits into from
Jan 20, 2020

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Jan 17, 2020

Fix integration tests after #38784 and #38190 broke them. Thanks @mmtr for paying attention and reporting the issue!

I removed the devdocs integration test completely, because it made sense only for the implementation that reads files from filesystem directly. Now, the file contents are part of the search index that's generated at runtime.

The rest was fixing up paths and module mappings in test/integration/jest.config.js.

@jsnajdr jsnajdr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Build labels Jan 17, 2020
@jsnajdr jsnajdr requested review from ockham, sgomes, sirreal, mmtr and a team January 17, 2020 13:15
@jsnajdr jsnajdr self-assigned this Jan 17, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@blowery blowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, integration tests pass locally

@jsnajdr jsnajdr merged commit 34bd8fd into master Jan 20, 2020
@jsnajdr jsnajdr deleted the fix/integration-tests branch January 20, 2020 07:58
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants