Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Remove NODE_PATH #39159

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Docker: Remove NODE_PATH #39159

merged 1 commit into from
Feb 4, 2020

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jan 30, 2020 •
edited
Loading

Changes proposed in this Pull Request

Testing instructions

@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Build [Type] Janitorial labels Jan 30, 2020
@sirreal sirreal self-assigned this Jan 30, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=remove/docker-node-path

@sirreal sirreal requested a review from a team January 30, 2020 10:01
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

jsnajdr
jsnajdr approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calypso.live works well, and I assume that proves that the Docker build is OK.

@blowery
Copy link
Contributor

blowery commented Feb 3, 2020

LGTM, thanks @sirreal!

@sirreal sirreal merged commit eb15126 into master Feb 4, 2020
@sirreal sirreal deleted the remove/docker-node-path branch February 4, 2020 10:16
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnajdr jsnajdr jsnajdr approved these changes

Assignees

@sirreal sirreal

Labels
Build [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sirreal @matticbot @blowery @jsnajdr