Add all monorepo packages as top-level deps #39218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
blowery
reviewed
Feb 3, 2020
| "requires": { | ||
| "babel-runtime": "^6.9.2", | ||
| "debug": "^3.1.0", | ||
| "@babel/runtime": "^7.8.3", |
There was a problem hiding this comment.
I think that's caused by the recent wpcom PRs that upgraded the package's dependencies, but not the lockfile.
There was a problem hiding this comment.
yeah, surprised npm ci wasn't yelling about it
There was a problem hiding this comment.
I think that npm ci doesn't look at the requires fields at all. It just blindly recreates the node_modules tree from the nested dependencies objects in the lockfile. For that, only the tree structure and the resolved and integrity fields are needed.
blowery
approved these changes
Feb 3, 2020
matticbot
removed
the
[Status] Needs Review
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all packages in the monorepo as dependencies of the top-level
package.json. Some of them already are there asdevDependencies. Here we are adding the rest.This is a workaround for NPM bug: npm/cli#750
How to test:
Do a clean (no
node_modules) install (notci) from the lockfile:Before this patch, the
npm installfailed to create symlinks to packages like@automattic/componentsand even removed the dependency from the lockfile.After the patch,
npm installshould install everything just likenpm ciand shouldn't change the lockfile at all.