Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component-tip to 2.5.0 #395

Merged
merged 1 commit into from
Nov 22, 2015
Merged

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Nov 21, 2015

To update another ms down the dependency chain to 0.7.1,
fixing https://nodesecurity.io/advisories/46.

To update another `ms` down the dependency chain to 0.7.1,
fixing https://nodesecurity.io/advisories/46.
@ockham ockham added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Security labels Nov 21, 2015
@ockham ockham self-assigned this Nov 21, 2015
@rralian rralian added [Pri] BLOCKER Requires immediate attention. OSS labels Nov 22, 2015
@rralian
Copy link
Contributor

rralian commented Nov 22, 2015

This looks good to me, I don't see any problems with popover, which looks like the only place we use component-tip. And I don't see anything worrying in the history.md for component-tip. :shipit:

@rralian rralian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 22, 2015
rralian added a commit that referenced this pull request Nov 22, 2015
@rralian rralian merged commit 52ad587 into master Nov 22, 2015
@rralian rralian deleted the update/component-tip-to-2-5-0 branch November 22, 2015 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework [Pri] BLOCKER Requires immediate attention. Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants