-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Allow pasting text to image caption #3986
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Post/Page Editor
The editor for editing posts and pages.
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
[Feature] Media
The media screen in Calypso, general media management, or integration with third party media.
labels
Mar 11, 2016
CC @azaozz for follow-up tasks. |
Bypasses mceInsertContent handler for inserting paragraph after caption if it’s determined the pasted content consists only of inline elements
aduth
added
[Status] In Progress
and removed
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
labels
Mar 15, 2016
Looks like this is still pending inclusion in core WordPress of the proposed change. |
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Media
The media screen in Calypso, general media management, or integration with third party media.
[Feature] Post/Page Editor
The editor for editing posts and pages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1658
This pull request seeks to resolve an issue where pasting while the current selection is within an image caption would cause the caption to be added to the paragraph following the image, not the image caption itself.
Testing instructions:
Verify that you can paste text into a caption, including when selecting the entire caption via double- or triple-click.
Follow-up tasks:
We should pursue one of the following:
paste
plugin to useeditor.selection.setContent
when pasting, in place ofeditor.insertContent