Test: Move simpler tests from lib/* to single test runner
#3988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
force-pushed
the
update/client-lib-tests-move
branch
from
365731f to
262f5d6
Compare
gziolo
force-pushed
the
update/client-lib-tests-move
branch
2 times, most recently
from
d379b60 to
1098f50
Compare
| @@ -27,6 +27,6 @@ function findQuickMocks( dirpath ) { | |||
| } ); | |||
| } | |||
|
|
|||
| export default function( dirpath ) { | |||
| export default function( dirpath = __dirname ) { | |||
There was a problem hiding this comment.
isn't this the path of this file though? I didn't provide a default because I think it's always wrong... but maybe I'm wrong?
There was a problem hiding this comment.
Yes, you are right. I forgot to remove my failed try to make it smarter :D
gziolo
force-pushed
the
update/client-lib-tests-move
branch
from
1098f50 to
48ba7e4
Compare
gziolo
added
[Status] Needs Review
|
/cc @blowery |
| @@ -11,7 +11,7 @@ var mockSites = null, | |||
| }, | |||
| actions; | |||
|
|
|||
| describe( 'Recommended Site Store Actions', function() { | |||
| describe( 'actions', function() { | |||
There was a problem hiding this comment.
Mockery setup a couple lines past should be cleaned up
There was a problem hiding this comment.
Updated to use mockery helper
|
🚢 looks good |
blowery
added
[Status] Ready to Merge
and removed
[Status] Needs Review
gziolo
added a commit
that referenced
this pull request
Mar 14, 2016
Test: Move simpler tests from `lib/*` to single test runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3942.
This PR removes 22
Makefilefiles located in `client/lib/* and moves related test suites to single test runner. In addition it also fixes all ESLint warnings found in modified test files.By design I skipped all test files that have filesystem mocks and use globals :)
Testing
clientfolder.make test.