People: Update follow invite explanation to mention WP.com reader #4026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Status] Needs Review
ebinnion
force-pushed
the
update/follower-explanation-in-reader
branch
from
9be28cd to
06506b8
Compare
|
Let's make 'Reader' have a leading capital. |
|
LGTM. Thanks for the changes 👍 |
ebinnion
added a commit
that referenced
this pull request
Mar 14, 2016
…in-reader People: Update follow invite explanation to mention WP.com reader
fabianapsimoes
removed
the
[Status] Needs Review
lancewillett
removed
the
[Status] Needs Design Review
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3929.
In #3929, @v18 suggested that we clarify to the user that updates will be shown in the WordPress.com reader for logged in invites.
I went ahead and applied this change to both logged in and logged out invites. I think this makes sense, because the option to follow via email is only displayed for logged out invites. Even then, it's a link at the bottom of the form.
cc @rickybanister for design review
To test:
update/follower-explanation-in-readerbranch/people/new/$siteand send a follower invite to an email you have control over